Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 537673002: Add --break-at-isolate-spawn to help with isolate debugging. (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org, devoncarew
Visibility:
Public.

Description

Add --break-at-isolate-spawn to help with isolate debugging. This flags stops spawned isolates with a one-time breakpoint at their entrypoints. Fix a bug in Observatory which interfered with browsing a spawned isolate. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39878

Patch Set 1 #

Patch Set 2 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -58 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/boot.js View 1 1 chunk +1 line, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/polymer.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log View 1 1 chunk +16 lines, -13 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 1 chunk +32 lines, -23 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/dart_support.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
6 years, 3 months ago (2014-09-03 18:31:52 UTC) #2
Cutch
lgtm
6 years, 3 months ago (2014-09-03 18:32:19 UTC) #3
turnidge
6 years, 3 months ago (2014-09-04 16:53:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698