Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 53683004: fix observe tests (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix observe tests looks like I was testing locally against an older VM, before the recent fix for unknown types Committed: https://code.google.com/p/dart/source/detail?r=29633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/observe/test/list_change_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/observe/test/observable_list_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
Committed patchset #1 manually as r29633 (presubmit successful).
7 years, 1 month ago (2013-10-31 02:50:40 UTC) #1
Jennifer Messerly
TBR
7 years, 1 month ago (2013-10-31 02:50:42 UTC) #2
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-31 02:51:22 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698