return correct replacementOffset and replacementLength

return correct replacementOffset and replacementLength

BUG=
R=jwren@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39789

[danrubel, 2014-09-02 21:56:31]

danrubel@google.com changed reviewers:
+ jwren@google.com

[jwren, 2014-09-02 22:04:49]

https://codereview.chromium.org/536593002/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/536593002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:77:
request.node.accept(new _ReplacementOffsetBuilder(request));
If all you are doing in this visitor is grabbing the offset and length from the
node, why do you need a visitor? Can't you just do this?

if(request.node != null) {
  request.replacementOffset = node.offset;
  request.replacementLength = node.length;
}

Creating a visitor and then using it to visit the node does take time for a fast
completion....

[jwren, 2014-09-02 22:35:39]

On 2014/09/02 22:04:49, jwren wrote:
>
https://codereview.chromium.org/536593002/diff/1/pkg/analysis_server/lib/src/...
> File
> pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
> (right):
> 
>
https://codereview.chromium.org/536593002/diff/1/pkg/analysis_server/lib/src/...
>
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:77:
> request.node.accept(new _ReplacementOffsetBuilder(request));
> If all you are doing in this visitor is grabbing the offset and length from
the
> node, why do you need a visitor? Can't you just do this?
> 
> if(request.node != null) {
>   request.replacementOffset = node.offset;
>   request.replacementLength = node.length;
> }
> 
> Creating a visitor and then using it to visit the node does take time for a
fast
> completion....

LGTM

[danrubel, 2014-09-03 00:55:27]

https://codereview.chromium.org/536593002/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart
(right):

https://codereview.chromium.org/536593002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart:77:
request.node.accept(new _ReplacementOffsetBuilder(request));
On 2014/09/02 22:04:49, jwren wrote:
> If all you are doing in this visitor is grabbing the offset and length from
the
> node, why do you need a visitor? Can't you just do this?
> 
> if(request.node != null) {
>   request.replacementOffset = node.offset;
>   request.replacementLength = node.length;
> }
> 
> Creating a visitor and then using it to visit the node does take time for a
fast
> completion....

It should be fast as I'm using a simple visitor just to dispatch based upon the
type of node. Per discussion, I'll keep the visitor.

[danrubel, 2014-09-03 00:55:44]

Committed patchset #2 (id:20001) manually as 39789 (presubmit successful).