Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 536543002: Revert "Fix scoping async functions." (Closed)

Created:
6 years, 3 months ago by Michael Lippautz (Google)
Modified:
6 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Revert "Fix scoping async functions." This reverts commit 7c03f3ef75f546c73d46680206cd7fe61997e1be. BUG= Committed: https://code.google.com/p/dart/source/detail?r=39777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -230 lines) Patch
M runtime/vm/ast_transformer.h View 3 chunks +12 lines, -5 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 7 chunks +27 lines, -61 lines 0 comments Download
M runtime/vm/parser.h View 9 chunks +22 lines, -16 lines 0 comments Download
M runtime/vm/parser.cc View 19 chunks +100 lines, -124 lines 0 comments Download
M tests/language/await_future_test.dart View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Lippautz (Google)
TBR passing tests on my machine but buildbot has a different opinion...
6 years, 3 months ago (2014-09-02 20:53:52 UTC) #2
Michael Lippautz (Google)
Committed patchset #1 (id:1) manually as 39777 (presubmit successful).
6 years, 3 months ago (2014-09-02 20:54:11 UTC) #3
hausner
6 years, 3 months ago (2014-09-02 20:57:26 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698