Teach the Observatory about WeakProperties (ephemerons).

Teach the Observatory about WeakProperties (ephemerons).

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39885

[rmacnak, 2014-09-04 00:52:45]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2014-09-04 15:27:24]

lgtm after adding service test.

https://codereview.chromium.org/536273002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/536273002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:1493: @observable
Instance value;  // If a WeakProperty.
I wonder if we should start subclassing Instance so we don't keep adding fields
for each instance type. Just a thought, not necessary for this change.

[rmacnak, 2014-09-04 20:36:07]

Added test

https://codereview.chromium.org/536273002/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/536273002/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:1493: @observable
Instance value;  // If a WeakProperty.
On 2014/09/04 15:27:24, Cutch wrote:
> I wonder if we should start subclassing Instance so we don't keep adding
fields
> for each instance type. Just a thought, not necessary for this change.

Right, and there are a lot more special Instance types this doesn't even handle
yet.

[rmacnak, 2014-09-04 20:36:44]

Committed patchset #3 (id:40001) manually as 39885 (presubmit successful).