Use JavaScript to detect if Selection.modify is available.

Use JavaScript to detect if Selection.modify is available.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39806

[ahe, 2014-09-03 09:55:37]

ahe@google.com changed reviewers:
+ aprelev@gmail.com, kasperl@google.com

[kasperl, 2014-09-03 12:55:18]

LGTM.

https://codereview.chromium.org/535883002/diff/1/dart/tests/try/firefox.apple...
File dart/tests/try/firefox.applescript (right):

https://codereview.chromium.org/535883002/diff/1/dart/tests/try/firefox.apple...
dart/tests/try/firefox.applescript:54: delay 0.1
I trust this does what you want.

[ahe, 2014-09-03 13:10:23]

Thank you, Kasper!

https://codereview.chromium.org/535883002/diff/1/dart/tests/try/firefox.apple...
File dart/tests/try/firefox.applescript (right):

https://codereview.chromium.org/535883002/diff/1/dart/tests/try/firefox.apple...
dart/tests/try/firefox.applescript:54: delay 0.1
On 2014/09/03 12:55:18, kasperl wrote:
> I trust this does what you want.

Yes. This is for "manual" testing on my Mac.

[ahe, 2014-09-03 13:44:40]

Committed patchset #2 (id:20001) manually as 39806 (presubmit successful).

[aam-me, 2014-09-04 11:17:24]

On 2014/09/03 13:10:23, ahe wrote:
> Thank you, Kasper!
> 
>
https://codereview.chromium.org/535883002/diff/1/dart/tests/try/firefox.apple...
> File dart/tests/try/firefox.applescript (right):
> 
>
https://codereview.chromium.org/535883002/diff/1/dart/tests/try/firefox.apple...
> dart/tests/try/firefox.applescript:54: delay 0.1
> On 2014/09/03 12:55:18, kasperl wrote:
> > I trust this does what you want.
> 
> Yes. This is for "manual" testing on my Mac.

Hi Peter, did you have to do some special set up to make those Firefox, Safari
scripts work?
I tried both unsuccessfully. I found that with Firerfox 31 I need to have more
tabs(9 vs 4) to get to the main editor div and then still it doesn't quite
work(delete deletes curly brace after "void main()" in Hello World example),
with Safari bookmark tab gets in the way of tabbing to main editor div as well.

[ahe, 2014-09-04 11:36:09]

On 2014/09/04 11:17:24, aam wrote:
> Hi Peter, did you have to do some special set up to make those Firefox, Safari
> scripts work?

Not besides running them on my Mac. Did you run them on a Mac?

> I tried both unsuccessfully. I found that with Firerfox 31 I need to have more
> tabs(9 vs 4) to get to the main editor div and then still it doesn't quite
> work(delete deletes curly brace after "void main()" in Hello World example),
> with Safari bookmark tab gets in the way of tabbing to main editor div as
well.

Yeah. Tabbing doesn't work. I wanted to see if I could use the same approach to
test IE11 via Remote Desktop, but it doesn't work.

So I've considered using accesskey attributes to make them more reliable.

[aam-me, 2014-09-04 11:49:13]

On 2014/09/04 11:36:09, ahe wrote:
> On 2014/09/04 11:17:24, aam wrote:
> > Hi Peter, did you have to do some special set up to make those Firefox,
Safari
> > scripts work?
> 
> Not besides running them on my Mac. Did you run them on a Mac?

Yes.

> > I tried both unsuccessfully. I found that with Firerfox 31 I need to have
more
> > tabs(9 vs 4) to get to the main editor div and then still it doesn't quite
> > work(delete deletes curly brace after "void main()" in Hello World example),
> > with Safari bookmark tab gets in the way of tabbing to main editor div as
> well.
> 
> Yeah. Tabbing doesn't work. I wanted to see if I could use the same approach
to
> test IE11 via Remote Desktop, but it doesn't work.
> 
> So I've considered using accesskey attributes to make them more reliable.

Ah, okay.