Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 53583003: Implement latest spec changes regarding malformed types (see issue 14006): (Closed)

Created:
7 years, 1 month ago by regis
Modified:
7 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org, gbracha
Visibility:
Public.

Description

Implement latest spec changes regarding malformed types (see issue 14006): - a malformed type used in a is, as, or catch type test results in a dynamic type error being thrown. - a malformed type is not mapped to dynamic anymore. For now, this applies to type tests in checked mode as well, but discussion is still on-going. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=29608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -128 lines) Patch
M runtime/lib/errors_patch.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +10 lines, -21 lines 0 comments Download
M runtime/vm/code_generator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 2 chunks +21 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 8 chunks +25 lines, -37 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/mint_maker_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/isolate/unresolved_ports_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/async/stream_event_transformed_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/issue14236_test.dart View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 1 month ago (2013-10-30 23:09:25 UTC) #1
hausner
LGTM
7 years, 1 month ago (2013-10-30 23:28:09 UTC) #2
regis
7 years, 1 month ago (2013-10-30 23:30:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698