Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 535543003: New analyzer snapshot. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer snapshot. We compute the parameter element for 'object.field = 42' now, so: 1. We can stop doing it in InlineMethodRefactoring. 2. We need to update the corresponding hover integration test. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1013 lines, -221 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 2 chunks +1 line, -36 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 3 chunks +55 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 82 chunks +218 lines, -162 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 7 chunks +20 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 12 chunks +94 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 21 chunks +608 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-09-02 20:05:16 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-02 20:09:49 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 39772 (presubmit successful).
6 years, 3 months ago (2014-09-02 20:10:55 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-02 20:14:19 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698