Issue 535413002: move delete_file and remove_sourcemap_comment transformers to code_transformers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 535413002: move delete_file and remove_sourcemap_comment transformers to code_transformers (Closed)

Created:
6 years, 3 months ago by jakemac

Modified:
6 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

move delete_file and remove_sourcemap_comment transformers to code_transformers R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=39842

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
M	pkg/code_transformers/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A +	pkg/code_transformers/lib/src/delete_file.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/code_transformers/lib/src/remove_sourcemap_comment.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/code_transformers/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/code_transformers/test/remove_sourcemap_comment_test.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Siggi Cherem (dart-lang)

let's move the 'remove_sourcemap_comment' test here too. Otherwise lgtm

6 years, 3 months ago (2014-09-03 22:23:38 UTC) #3

jakemac

6 years, 3 months ago (2014-09-03 22:37:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 39842 (presubmit successful).