Issue 53503002: Fix logging call in path_observer (issue 14617)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53503002: Fix logging call in path_observer (issue 14617) (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/observe/lib/src/path_observer.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Jennifer Messerly

lgtm. do you mind changing _logger to use the explicit Logger type, so analyzer can ...

7 years, 1 month ago (2013-10-30 22:13:16 UTC) #2

Siggi Cherem (dart-lang)

On 2013/10/30 22:13:16, John Messerly wrote: > lgtm. do you mind changing _logger to use ...

7 years, 1 month ago (2013-10-30 22:15:38 UTC) #3

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-10-30 22:17:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29597 (presubmit successful).