Bump allocation for promotion

During promotion, use bump allocation whenever there are no small blocks available.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39893

[koda, 2014-09-04 05:26:28]

koda@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2014-09-04 21:50:47]

LGTM with comments addressed.

-Ivan

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/freelist.cc
File runtime/vm/freelist.cc (right):

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/freelist.cc#...
runtime/vm/freelist.cc:360: FreeListElement*
FreeList::TryAllocateLargeLocked(intptr_t minimum_size) {
DEBUG_ASSERT(mutex_->Owner() == Isolate::Current());

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/freelist.cc#...
runtime/vm/freelist.cc:382: int index = IndexForSize(size);
FreeList::TryAllocateSmallLocked
and
DEBUG_ASSERT(mutex_->Owner() == Isolate::Current());

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:773: template<bool is_locked>
Please use a real parameter instead.

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:835: uword PageSpace::TryAllocatePromo(intptr_t size,
GrowthPolicy growth_policy) {
TryAllocatePromoLocked

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:838: if (size <= freelist->SmallSizeBound()) {
Please roll these into a single API.

[koda, 2014-09-05 00:24:53]

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/freelist.cc
File runtime/vm/freelist.cc (right):

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/freelist.cc#...
runtime/vm/freelist.cc:360: FreeListElement*
FreeList::TryAllocateLargeLocked(intptr_t minimum_size) {
On 2014/09/04 21:50:46, Ivan Posva wrote:
> DEBUG_ASSERT(mutex_->Owner() == Isolate::Current());

Done.

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/freelist.cc#...
runtime/vm/freelist.cc:382: int index = IndexForSize(size);
On 2014/09/04 21:50:46, Ivan Posva wrote:
> FreeList::TryAllocateSmallLocked
> and
> DEBUG_ASSERT(mutex_->Owner() == Isolate::Current());

Done.

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:773: template<bool is_locked>
On 2014/09/04 21:50:47, Ivan Posva wrote:
> Please use a real parameter instead.

Done.

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:835: uword PageSpace::TryAllocatePromo(intptr_t size,
GrowthPolicy growth_policy) {
On 2014/09/04 21:50:47, Ivan Posva wrote:
> TryAllocatePromoLocked

Done.

https://codereview.chromium.org/534653002/diff/140001/runtime/vm/pages.cc#new...
runtime/vm/pages.cc:838: if (size <= freelist->SmallSizeBound()) {
On 2014/09/04 21:50:47, Ivan Posva wrote:
> Please roll these into a single API.

Done.

[koda, 2014-09-05 01:08:03]

Committed patchset #9 (id:160001) manually as r39893 (presubmit successful).