Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 534273002: Remove debug logging from builtin. (Closed)

Created:
6 years, 3 months ago by Anders Johnsen
Modified:
6 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove debug logging from builtin. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39897

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Default to false. #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M runtime/bin/builtin.dart View 1 2 3 4 11 chunks +36 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Anders Johnsen
6 years, 3 months ago (2014-09-03 14:51:42 UTC) #2
Ivan Posva
LGTM, but I am wondering whether there is a way to keep the logging code ...
6 years, 3 months ago (2014-09-03 15:39:39 UTC) #3
Anders Johnsen
PTAL
6 years, 3 months ago (2014-09-04 11:17:15 UTC) #4
Ivan Posva
LGTMwC -Ivan https://codereview.chromium.org/534273002/diff/60001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/534273002/diff/60001/runtime/bin/builtin.dart#newcode30 runtime/bin/builtin.dart:30: final _logBuiltin = false; const? https://codereview.chromium.org/534273002/diff/60001/runtime/bin/builtin.dart#newcode108 runtime/bin/builtin.dart:108: ...
6 years, 3 months ago (2014-09-04 15:35:25 UTC) #5
Anders Johnsen
https://codereview.chromium.org/534273002/diff/60001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/534273002/diff/60001/runtime/bin/builtin.dart#newcode30 runtime/bin/builtin.dart:30: final _logBuiltin = false; On 2014/09/04 15:35:25, Ivan Posva ...
6 years, 3 months ago (2014-09-05 05:36:59 UTC) #6
Anders Johnsen
6 years, 3 months ago (2014-09-05 05:38:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 39897 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698