Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 533273003: Use unit + offset as 'Inline Local' arguments. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use unit + offset as 'Inline Local' arguments. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 3 chunks +19 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 3 chunks +34 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-03 18:28:46 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-03 18:39:56 UTC) #2
scheglov
6 years, 3 months ago (2014-09-03 18:45:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698