Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 533243002: Merge analysis_testing package into analysis_server. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Merge analysis_testing package into analysis_server. Note that analysis_server already contains a file test/mocks.dart, so the mocks.dart file from analysis_testing has been imported as test/mocks2.dart. I will merge these two into a single file in a future CL. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -819 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +0 lines, -1 line 0 comments Download
A + pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_after_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_before_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/get_version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/shutdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/status_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/mock_sdk.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_server/test/mocks2.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/reflective_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_manager_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_type_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/correction/levenshtein_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/strings_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/local_index_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/collection_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/temporary_folder_file_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D pkg/analysis_testing/LICENSE View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/analysis_testing/lib/abstract_context.dart View 1 chunk +0 lines, -103 lines 0 comments Download
D pkg/analysis_testing/lib/abstract_single_unit.dart View 1 chunk +0 lines, -105 lines 0 comments Download
D pkg/analysis_testing/lib/mock_sdk.dart View 1 chunk +0 lines, -222 lines 0 comments Download
D pkg/analysis_testing/lib/mocks.dart View 1 chunk +0 lines, -153 lines 0 comments Download
D pkg/analysis_testing/lib/reflective_tests.dart View 1 chunk +0 lines, -89 lines 0 comments Download
D pkg/analysis_testing/pubspec.yaml View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/analysis_testing/test/test_all.dart View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-03 17:24:19 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-03 17:28:05 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-03 18:12:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as 39814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698