Disable Google Analytics in automated tests.

Disable Google Analytics in automated tests.

R=lukechurch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39863

[ahe, 2014-09-04 08:56:43]

ahe@google.com changed reviewers:
+ lukechurch@google.com

[ahe, 2014-09-04 08:56:44]

I'm worried that our automated tests are skewing our usage statistics.

[lukechurch, 2014-09-04 09:20:55]

Are we sure that the order of execution here is correct? That the
document.cookie set will occur before the JS that tests for the analytics
cookie?

Could we harden the test by setting a flag in the JS and failing the test if
that flag has been set?

[ahe, 2014-09-04 11:07:17]

https://codereview.chromium.org/532953003/diff/1/dart/site/try/index.html
File dart/site/try/index.html (right):

https://codereview.chromium.org/532953003/diff/1/dart/site/try/index.html#new...
dart/site/try/index.html:193: if
(document.cookie.split(';').indexOf('org-trydart-AutomatedTest=true') != -1) {
If I add:

window.parent && window.parent.postMessage('Enabled analytics.', '*');

The test will fail if analytics are enabled. I know this because I added an else
block that instead posted "disabled analytics" after line 203 and verified that
the test failed.

Would that ease your concerns?

https://codereview.chromium.org/532953003/diff/1/dart/tests/try/web/end_to_en...
File dart/tests/try/web/end_to_end_test.dart (right):

https://codereview.chromium.org/532953003/diff/1/dart/tests/try/web/end_to_en...
dart/tests/try/web/end_to_end_test.dart:72: document.cookie =
'org-trydart-AutomatedTest=true';
This is before the iframe below is created.

[lukechurch, 2014-09-04 11:18:21]

Yes, based on the whitelist posting that message to the log if analytics is
enabled and then verifying that it isn't there in the tests is fine.

[ahe, 2014-09-04 12:03:20]

PTAL

[lukechurch, 2014-09-04 12:04:57]

Fix looks good. Thanks.

lgtm

[ahe, 2014-09-04 12:12:00]

Committed patchset #2 (id:20001) manually as 39863 (presubmit successful).