Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 53243002: Use pub-build in todomvc and sample template app from the editor (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use pub-build in todomvc and sample template app from the editor, and update docs R=jmesserly@google.com, keertip@google.com Committed: https://code.google.com/p/dart/source/detail?r=29607

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -16 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/PolymerSample.java View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/polymer/README.md View 1 2 1 chunk +42 lines, -15 lines 0 comments Download
M samples/third_party/todomvc/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
Seth - can you take a closer look at the README
7 years, 1 month ago (2013-10-30 20:29:37 UTC) #1
Jennifer Messerly
LGTM but -- how is the editor UI for editing pubspec now? Does it handle ...
7 years, 1 month ago (2013-10-30 20:31:25 UTC) #2
Siggi Cherem (dart-lang)
On 2013/10/30 20:31:25, John Messerly wrote: > LGTM but -- how is the editor UI ...
7 years, 1 month ago (2013-10-30 20:34:58 UTC) #3
sethladd
Star https://code.google.com/p/dart/issues/detail?id=14624
7 years, 1 month ago (2013-10-30 20:57:48 UTC) #4
keertip
LGTM!
7 years, 1 month ago (2013-10-30 22:41:53 UTC) #5
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-30 23:01:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r29607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698