Issue 532333002: Merge analysis server's mocks.dart and mocks2.dart into one file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 532333002: Merge analysis server's mocks.dart and mocks2.dart into one file. (Closed)

Created:
6 years, 3 months ago by Paul Berry

Modified:
6 years, 3 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Merge analysis server's mocks.dart and mocks2.dart into one file. There were competing implementations of MockAnalysisContext and MockSource, but one of the implementations was only used in one place (analysis_server_test.dart), so it's been switched over to use the other implementation. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39826

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -182 lines)			Patch
M	pkg/analysis_server/test/analysis_server_test.dart	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/test/computer/error_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/mocks.dart	View	3 chunks	+146 lines, -17 lines	0 comments	Download
D	pkg/analysis_server/test/mocks2.dart	View	1 chunk	+0 lines, -153 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/store/codec_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/store/split_store_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/search/search_engine_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

6 years, 3 months ago (2014-09-03 19:45:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 39826 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages