Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 530033002: Use a more precise type for "object" in analysis server API. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use a more precise type for "object" in analysis server API. Previously, we translated "object" in the API to the dart type "Object". But this is not correct, since in the API when we say "object" we mean "JSON object", which corresponds to a Dart Map. Using a more precise type exposed some bugs in our refactoring implementation, where we were forgetting to convert objects to and from JSON. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -107 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 5 chunks +10 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 93 chunks +93 lines, -93 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/services/json.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 6 chunks +10 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-02 16:47:45 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-02 16:58:58 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-02 17:46:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698