Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 529313002: Fix for NPE in the server. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for NPE in the server. I think that is the same NPE we saw in both Dart and Java last week. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -50 lines) Patch
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 3 chunks +62 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-09-03 02:51:09 UTC) #1
Paul Berry
lgtm
6 years, 3 months ago (2014-09-03 12:56:12 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-03 13:48:34 UTC) #3
scheglov
6 years, 3 months ago (2014-09-03 14:55:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698