Cleanup resource loading of the VM.

Cleanup resource loading of the VM.

There is not only one path for loading resources, and it's async.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39847

[Anders Johnsen, 2014-09-03 10:53:04]

ajohnsen@google.com changed reviewers:
+ iposva@google.com

[Anders Johnsen, 2014-09-03 10:53:04]

I see no notable performance differences so far.

[Ivan Posva, 2014-09-03 15:33:08]

LGTMwC

-Ivan

https://codereview.chromium.org/529203004/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/529203004/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:210: void _httpGet(Uri uri, String libraryUri,
loadCallback(List<int> data)) {
Please confirm that this chunk of code was just copied down here without
modification.

https://codereview.chromium.org/529203004/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/529203004/diff/1/runtime/bin/dartutils.cc#new...
runtime/bin/dartutils.cc:597: Dart_Handle DartUtils::LoadSource(Dart_Handle
library,
I would expect that we can remove this entirely or at least it should be renamed
to signal the async nature.

[Anders Johnsen, 2014-09-04 06:41:50]

https://codereview.chromium.org/529203004/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/529203004/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:210: void _httpGet(Uri uri, String libraryUri,
loadCallback(List<int> data)) {
On 2014/09/03 15:33:07, Ivan Posva wrote:
> Please confirm that this chunk of code was just copied down here without
> modification.

It is - I just moved it here to group the functions a bit.

https://codereview.chromium.org/529203004/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/529203004/diff/1/runtime/bin/dartutils.cc#new...
runtime/bin/dartutils.cc:597: Dart_Handle DartUtils::LoadSource(Dart_Handle
library,
On 2014/09/03 15:33:07, Ivan Posva wrote:
> I would expect that we can remove this entirely or at least it should be
renamed
> to signal the async nature.

Still used in gen_snapshot. Renamed.

[Anders Johnsen, 2014-09-04 06:42:13]

Committed patchset #2 (id:20001) manually as 39847 (presubmit successful).