Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 529123002: Make findElementReferences' "id" result optional. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make findElementReferences' "id" result optional. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -28 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/SearchIdProcessor.java View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 2 chunks +7 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 4 chunks +9 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 2 chunks +7 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-02 19:51:40 UTC) #2
jwren
On 2014/09/02 19:51:40, Paul Berry wrote: LGTM, thanks for breaking up the spec_input changes. I ...
6 years, 3 months ago (2014-09-02 19:56:14 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-02 20:11:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698