Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 52883002: Remove uses of Options in polymer lint and deploy tools. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), Jennifer Messerly, scheglov
Visibility:
Public.

Description

Remove uses of Options in polymer lint and deploy tools. BUG= R=sgjesse@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29569

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
M pkg/polymer/lib/builder.dart View 9 chunks +26 lines, -12 lines 3 comments Download
M pkg/polymer/lib/deploy.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
This has to go in so we can remove the Options class. If it breaks ...
7 years, 1 month ago (2013-10-30 17:34:09 UTC) #1
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-30 17:42:32 UTC) #2
Siggi Cherem (dart-lang)
lgtm This is going to be a breaking change for polymer users. Most users need ...
7 years, 1 month ago (2013-10-30 17:43:32 UTC) #3
Bill Hesse
7 years, 1 month ago (2013-10-30 17:44:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698