Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 52853003: Configure polymer transformers based on whether pub is running the build or (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Configure polymer transformers based on whether pub is running the build or serve command. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=29710

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/polymer/lib/transformer.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-31 01:17:25 UTC) #1
Bob Nystrom
Change "transformer" -> "configuration" then LGTM!
7 years, 1 month ago (2013-10-31 21:16:11 UTC) #2
Siggi Cherem (dart-lang)
thanks! All set.
7 years, 1 month ago (2013-10-31 22:09:24 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-31 22:27:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r29710 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698