Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 528053002: Rename ExecutableFile.offset to ExecutableFile.kind and fix documentation. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Rename ExecutableFile.offset to ExecutableFile.kind and fix documentation. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExecutableFile.java View 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 6 chunks +12 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-02 20:07:13 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-02 20:09:18 UTC) #3
Paul Berry
6 years, 3 months ago (2014-09-02 20:13:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698