Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 52803002: Adds support for ARM softfp calling convention. (Closed)

Created:
7 years, 1 month ago by zra
Modified:
7 years, 1 month ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds support for ARM softfp calling convention. The cross-compiler with the Android NDK doesn't support the 'hard' calling convention, so we need both. I've added a preprocessor define to the gyp file for the standalone vm indicating support for 'hard' so that I don't have to modify the Dartium gyp files. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29577

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -9 lines) Patch
M runtime/vm/intermediate_language_arm.cc View 1 4 chunks +38 lines, -4 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 3 chunks +24 lines, -5 lines 0 comments Download
M tools/build.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
7 years, 1 month ago (2013-10-30 17:59:54 UTC) #1
zra
Regis's hair is on fire, so: -regis +srdjan,asiva.
7 years, 1 month ago (2013-10-30 18:24:47 UTC) #2
srdjan
lgtm
7 years, 1 month ago (2013-10-30 18:39:22 UTC) #3
zra
7 years, 1 month ago (2013-10-30 18:58:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698