Issue 52753003: Fix builder.dart - avoid breaking users, print a warning instead and continue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52753003: Fix builder.dart - avoid breaking users, print a warning instead and continue (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
Bill Hesse, Jennifer Messerly

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix builder.dart - avoid breaking users, print a warning instead and continue with a default. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29588

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
	M	pkg/polymer/lib/builder.dart	View		4 chunks	+12 lines, -14 lines	0 comments	Download

Total messages: 6 (0 generated)

Siggi Cherem (dart-lang)

Committed patchset #1 manually as r29588 (presubmit successful).

7 years, 1 month ago (2013-10-30 21:31:04 UTC) #4

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-10-30 23:39:35 UTC) #6

Message was sent while issue was closed.

On 2013/10/30 23:38:17, Bill Hesse wrote:
> Lgtm - I guess I didn't need to be so drastic.

:-)