Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 527053002: Support passing in a test suite directory through a flag to the testing scripts (Closed)

Created:
6 years, 3 months ago by ricow1
Modified:
6 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support passing in a test suite directory through a flag to the testing scripts This will allow us to setup testing that mirrors what we currently have even with the packages moved to github. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39735

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -44 lines) Patch
M tools/test.dart View 1 chunk +47 lines, -33 lines 1 comment Download
M tools/testing/dart/test_options.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +9 lines, -11 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
ricow1
https://codereview.chromium.org/527053002/diff/1/tools/test.dart File tools/test.dart (right): https://codereview.chromium.org/527053002/diff/1/tools/test.dart#newcode190 tools/test.dart:190: for (String key in selectors.keys) { this and below ...
6 years, 3 months ago (2014-09-01 13:00:49 UTC) #2
Bill Hesse
lgtm
6 years, 3 months ago (2014-09-01 13:09:09 UTC) #3
ricow1
6 years, 3 months ago (2014-09-02 05:20:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r39735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698