Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 526823002: Use ResourceProvider instead of specialized setRealRoot/setFakeRoot. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use ResourceProvider instead of specialized setRealRoot/setFakeRoot. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M pkg/analyzer2dart/bin/analyzer2dart.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer2dart/lib/src/driver.dart View 3 chunks +10 lines, -23 lines 0 comments Download
M pkg/analyzer2dart/test/driver_test.dart View 3 chunks +13 lines, -10 lines 0 comments Download
M pkg/analyzer2dart/test/tree_shaker_test.dart View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-08-31 17:09:37 UTC) #1
Paul Berry
This is much cleaner. Thanks. lgtm
6 years, 3 months ago (2014-08-31 17:18:47 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-08-31 17:29:52 UTC) #3
scheglov
6 years, 3 months ago (2014-08-31 18:54:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39721 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698