'Inline Method' refactoring.

'Inline Method' refactoring.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39719

[Brian Wilkerson, 2014-08-31 15:59:56]

LGTM

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:210: String
getLinesPrefix(String lines) {
Should "lines" be "line"?

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:428:
accessor.variable.enclosingElement is ClassElement;
Do we have field elements whose parent is not a class element?

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/inline_method.dart
(right):

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:25: *
Resolver sets [ParameterElement] for the most cases, but not for setter
invocation.
First, the resolver never sets the parameter elements, they are computed when
requested. That implies that either the computation is wrong or that the
resolver isn't setting the element for the assignment to the setter. Shouldn't
this be fixed by either fixing the computation of the parameter element or by
fixing the resolver so that the right element is associated with the assignment
expression?

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:31: if
(expr.parent is AssignmentExpression) {
Alternatively, assign "expr.parent" to a local variable before the test and
avoid the need for the cast altogether.

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:85:
part._parameters.forEach((ParameterElement parameter, occurrences) {
Missing type annotation on "occurrences".

[scheglov, 2014-08-31 16:43:23]

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:210: String
getLinesPrefix(String lines) {
On 2014/08/31 15:59:56, Brian Wilkerson wrote:
> Should "lines" be "line"?

Acknowledged.

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:428:
accessor.variable.enclosingElement is ClassElement;
On 2014/08/31 15:59:56, Brian Wilkerson wrote:
> Do we have field elements whose parent is not a class element?

Yes, we do.
Although we are not interested in it for "Inline Method" refactoring.
I will rename this function to "isClassFieldAccessorElement".

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/inline_method.dart
(right):

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:25: *
Resolver sets [ParameterElement] for the most cases, but not for setter
invocation.
On 2014/08/31 15:59:56, Brian Wilkerson wrote:
> First, the resolver never sets the parameter elements, they are computed when
> requested. That implies that either the computation is wrong or that the
> resolver isn't setting the element for the assignment to the setter. Shouldn't
> this be fixed by either fixing the computation of the parameter element or by
> fixing the resolver so that the right element is associated with the
assignment
> expression?

The underlaying problem is that for "f = 0" the AssignmentExpression doesn't
have a static element.
I will investigate this.

https://codereview.chromium.org/526583002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/inline_method.dart:85:
part._parameters.forEach((ParameterElement parameter, occurrences) {
On 2014/08/31 15:59:56, Brian Wilkerson wrote:
> Missing type annotation on "occurrences".

Fixed.

[scheglov, 2014-08-31 16:43:49]

Committed patchset #2 (id:20001) manually as 39719 (presubmit successful).