Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 526263002: Remove unneeded generation of default constructors from the dart backend. (Closed)

Created:
6 years, 3 months ago by Johnni Winther
Modified:
6 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unneeded generation of default constructors from the dart backend. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=39737

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added another test. #

Patch Set 3 : Added language test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -60 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 chunk +0 lines, -42 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_backend_test.dart View 1 3 chunks +45 lines, -3 lines 0 comments Download
A + tests/language/unresolved_default_constructor_test.dart View 1 2 1 chunk +9 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
6 years, 3 months ago (2014-09-02 08:46:56 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/526263002/diff/1/tests/compiler/dart2js/backend_dart/dart_backend_test.dart File tests/compiler/dart2js/backend_dart/dart_backend_test.dart (right): https://codereview.chromium.org/526263002/diff/1/tests/compiler/dart2js/backend_dart/dart_backend_test.dart#newcode881 tests/compiler/dart2js/backend_dart/dart_backend_test.dart:881: testUnresolvedNamedConstructor1() { Maybe it is nicer to keep ...
6 years, 3 months ago (2014-09-02 09:14:07 UTC) #3
Johnni Winther
6 years, 3 months ago (2014-09-02 10:01:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 39737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698