Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 52573002: Remove uses of Options from pkg, samples, tests, and third_party directories. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove uses of Options from pkg, samples, tests, and third_party directories. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29552

Patch Set 1 #

Patch Set 2 : Edit comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -86 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/generator/chrome/build.dart View 1 chunk +1 line, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src-dart/pub_package_server.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/example/resolver_driver.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/example/scanner_driver.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/coverage_impl.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/args/lib/args.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/csslib/lib/css.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/csslib/test/run_all.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/docgen/bin/docgen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/docgen/lib/docgen.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/http_server/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/message_extraction/extract_to_json.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/generate_from_json.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/make_hardcoded_translation.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/source_maps/test/run.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/third_party/html5lib/test/run_all.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/third_party/html5lib/test/support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/watcher/example/watch.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M samples/build_dart/build.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M samples/build_dart_simple/build.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/basic_debugger_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/debugger/breakpoint_resolved_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/closure_debugger_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/standalone/debugger/nosuchmethod_debugger_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/step_in_equals_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/step_inout_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/debugger/stepping_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/debugger/tostring_throws_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/code_collection_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/pkg/js/build.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/pkg/js/tools/create_bootstrap.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-10-30 13:45:09 UTC) #1
Søren Gjesse
LGTM!
7 years, 1 month ago (2013-10-30 14:04:19 UTC) #2
Bill Hesse
7 years, 1 month ago (2013-10-30 15:17:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r29552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698