Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 524463006: Use MockSdk to speed-up tests. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rollback r39701 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M pkg/analyzer2dart/bin/analyzer2dart.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer2dart/lib/src/driver.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer2dart/test/driver_test.dart View 2 chunks +9 lines, -4 lines 0 comments Download
M pkg/analyzer2dart/test/tree_shaker_test.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scheglov
6 years, 3 months ago (2014-08-30 02:39:18 UTC) #1
Paul Berry
lgtm
6 years, 3 months ago (2014-08-30 05:31:04 UTC) #2
Paul Berry
On 2014/08/30 05:31:04, Paul Berry wrote: > lgtm Follow-up question: I'm assuming this is a ...
6 years, 3 months ago (2014-08-30 05:42:21 UTC) #3
scheglov
On 2014/08/30 05:42:21, Paul Berry wrote: > On 2014/08/30 05:31:04, Paul Berry wrote: > > ...
6 years, 3 months ago (2014-08-30 05:49:55 UTC) #4
scheglov
Committed patchset #2 (id:20001) manually as 39717 (presubmit successful).
6 years, 3 months ago (2014-08-30 05:51:15 UTC) #5
Brian Wilkerson
6 years, 3 months ago (2014-08-31 16:04:35 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698