Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 52443007: Allow matchingTarget to also include the currentTarget. (Closed)

Created:
7 years, 1 month ago by Emily Fortuna
Modified:
7 years, 1 month ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow matchingTarget to also include the currentTarget. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=29609

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -18 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +11 lines, -6 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emily Fortuna
7 years, 1 month ago (2013-10-30 22:57:24 UTC) #1
Emily Fortuna
(explanation: I believe currentTarget can also be matchingTarget, since it's the outermost parent which which ...
7 years, 1 month ago (2013-10-30 22:58:04 UTC) #2
blois
https://codereview.chromium.org/52443007/diff/1/tools/dom/templates/html/impl/impl_Event.darttemplate File tools/dom/templates/html/impl/impl_Event.darttemplate (right): https://codereview.chromium.org/52443007/diff/1/tools/dom/templates/html/impl/impl_Event.darttemplate#newcode53 tools/dom/templates/html/impl/impl_Event.darttemplate:53: while (matchedTarget == null && target != currentTarget.parent && ...
7 years, 1 month ago (2013-10-30 23:12:38 UTC) #3
Emily Fortuna
https://codereview.chromium.org/52443007/diff/1/tools/dom/templates/html/impl/impl_Event.darttemplate File tools/dom/templates/html/impl/impl_Event.darttemplate (right): https://codereview.chromium.org/52443007/diff/1/tools/dom/templates/html/impl/impl_Event.darttemplate#newcode53 tools/dom/templates/html/impl/impl_Event.darttemplate:53: while (matchedTarget == null && target != currentTarget.parent && ...
7 years, 1 month ago (2013-10-30 23:30:20 UTC) #4
blois
lgtm
7 years, 1 month ago (2013-10-30 23:31:53 UTC) #5
Emily Fortuna
7 years, 1 month ago (2013-10-30 23:32:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r29609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698