Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 52333002: Update type signature of JSON codec. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update type signature of JSON codec. The encode function should definitely return a String. The decode function returns an object of one of a known set of types. We can't specify that, but we can use dynamic instead of Object. This allows a user to write: JSON.decode('{"x":42}')["x"] without warnings. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sdk/lib/convert/json.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-30 10:34:31 UTC) #1
floitsch
LGTM.
7 years, 1 month ago (2013-10-30 17:57:40 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 10:24:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29661 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698