Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 52183003: Fix co19-dartium status, couple of tests are marked as expected to Fail but they actually pass on d… (Closed)

Created:
7 years, 1 month ago by siva
Modified:
7 years, 1 month ago
Reviewers:
regis, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix co19-dartium status, couple of tests are marked as expected to Fail but they actually pass on dartium. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=29621

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M dart/tests/co19/co19-dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/co19/co19-dartium.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/co19/co19-runtime.status View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
siva
7 years, 1 month ago (2013-10-31 00:38:53 UTC) #1
kustermann
LGTM -- I just wanted to look at the failures after the buildbot issues were ...
7 years, 1 month ago (2013-10-31 00:41:20 UTC) #2
kustermann
Commiting to get the buildbot green. @regis: The import test seems to fail on dartium ...
7 years, 1 month ago (2013-10-31 01:24:09 UTC) #3
kustermann
Committed patchset #2 manually as r29621 (presubmit successful).
7 years, 1 month ago (2013-10-31 01:24:30 UTC) #4
regis
7 years, 1 month ago (2013-10-31 01:41:16 UTC) #5
Message was sent while issue was closed.
On 2013/10/31 01:24:30, kustermann wrote:
> Committed patchset #2 manually as r29621 (presubmit successful).

Thanks for fixing. Sorry about that.

I am looking at the remaining analyzer failure now.

Powered by Google App Engine
This is Rietveld 408576698