Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 52123002: Fire event and close the stream when the watched directory is moved. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fire event and close the stream when the watched directory is moved. BUG=https://code.google.com/p/dart/issues/detail?id=14598 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29532

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Always listen for move self. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M runtime/bin/file_system_watcher_linux.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_system_watcher_test.dart View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-10-30 07:20:56 UTC) #1
Søren Gjesse
lgtm, but how about Mac OS?
7 years, 1 month ago (2013-10-30 11:34:07 UTC) #2
Anders Johnsen
7 years, 1 month ago (2013-10-30 11:35:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r29532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698