Use userAgent instead of webkitStartDart

Use userAgent instead of webkitStartDart

This modifies our browser package and test scripts to use the
userAgent instead of webkitStartDart (which is gone) to determine if
we have native dart support.

I'm TBR-ing to get rid of a ton of warnings on the Dartium bots (they
are trying to run both native tests (successfully) and compiled-to-js
tests (warning no js file)).

E.g., see HttpServer warnings on this otherwise green run:

http://chromegw.corp.google.com/i/client.dart/builders/dartium-mac-inc-be/builds/634/steps/drt_core_checked_tests/logs/stdio

Siggi: you have comments elsewhere around removing/refactoring when
webkitStartDart is gone.  They are still there.

TBR=sigmund@google.com,ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29515

[vsm, 2013-10-30 04:08:23]

https://chromiumcodereview.appspot.com/52023002/diff/1/tests/html/html.status
File tests/html/html.status (left):

https://chromiumcodereview.appspot.com/52023002/diff/1/tests/html/html.status...
tests/html/html.status:36: js_interop_2_test: Fail # Issue 14604
Note, this test broke when I removed webkitStartDart.  It's working now that
dart.js is using userAgent instead.

[vsm, 2013-10-30 04:08:46]

Committed patchset #1 manually as r29515 (presubmit successful).

[ricow1, 2013-10-30 06:35:25]

Is that really the way we will be able to figure out if dart is supported on the
platform?

https://codereview.chromium.org/52023002/diff/1/client/dart.js
File client/dart.js (right):

https://codereview.chromium.org/52023002/diff/1/client/dart.js#newcode13
client/dart.js:13: if (navigator.userAgent.indexOf('(Dart)') === -1) {
indexOf should always return a number, so strictly speaking you don't need ===
here.
Additionally, isn't the innerHTML setting still valid if the build is expired?

https://codereview.chromium.org/52023002/diff/1/pkg/browser/lib/dart.js
File pkg/browser/lib/dart.js (right):

https://codereview.chromium.org/52023002/diff/1/pkg/browser/lib/dart.js#newcode7
pkg/browser/lib/dart.js:7: if (navigator.userAgent.indexOf('(Dart)') === -1) {
same comment as before

[Siggi Cherem (dart-lang), 2013-10-30 14:56:58]

BTW, unittest/lib/test_controller.js also calls webkitStartDart. You might need
that fixed to get the bots happy.

[ricow1, 2013-10-30 16:56:57]

On 2013/10/30 14:56:58, Siggi Cherem (dart-lang) wrote:
> BTW, unittest/lib/test_controller.js also calls webkitStartDart. You might
need
> that fixed to get the bots happy.

Strictly speaking it does not call it unless it is defined :-)

But yes, we should remove it there as well, that is just dead code now