Issue 52003002: - Workaround SVN inconsistencies when building locally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52003002: - Workaround SVN inconsistencies when building locally. (Closed)

Created:
7 years, 1 month ago by Ivan Posva

Modified:
7 years, 1 month ago

Reviewers:
devoncarew, kustermann

CC:
reviews_dartlang.org, turnidge

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Workaround SVN inconsistencies when building locally. R=devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=29516

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tools/utils.py	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r29516 (presubmit successful).

7 years, 1 month ago (2013-10-30 04:32:31 UTC) #3

kustermann

7 years, 1 month ago (2013-10-30 11:15:21 UTC) #4

Message was sent while issue was closed.

This is hackisch ivan. Other build scripts could invoke svn -- and all
invocations of svn will fail if the svn client version is not compatible with
the one used to checkout.

https://codereview.chromium.org/52003002/diff/1/tools/utils.py
File tools/utils.py (right):

https://codereview.chromium.org/52003002/diff/1/tools/utils.py#newcode305
tools/utils.py:305: if user != 'chrome-bot':
Where is 'user' defined?

Expand Messages | Collapse Messages