Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 518853002: pkg/yaml prepare for release (Closed)

Created:
6 years, 3 months ago by kevmoo
Modified:
6 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : only a +1 release #

Total comments: 4

Patch Set 3 : less churn #

Total comments: 2

Patch Set 4 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/yaml/CHANGELOG.md View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/yaml/pubspec.yaml View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kevmoo
kevmoo@google.com changed reviewers: + nweiz@google.com
6 years, 3 months ago (2014-08-29 15:46:32 UTC) #1
kevmoo
6 years, 3 months ago (2014-08-29 15:46:32 UTC) #2
nweiz
https://codereview.chromium.org/518853002/diff/20001/pkg/yaml/pubspec.yaml File pkg/yaml/pubspec.yaml (right): https://codereview.chromium.org/518853002/diff/20001/pkg/yaml/pubspec.yaml#newcode7 pkg/yaml/pubspec.yaml:7: sdk: '>=1.5.0 <2.0.2' What exactly does this depend on ...
6 years, 3 months ago (2014-08-29 17:05:57 UTC) #3
kevmoo
PTAL https://codereview.chromium.org/518853002/diff/20001/pkg/yaml/pubspec.yaml File pkg/yaml/pubspec.yaml (right): https://codereview.chromium.org/518853002/diff/20001/pkg/yaml/pubspec.yaml#newcode7 pkg/yaml/pubspec.yaml:7: sdk: '>=1.5.0 <2.0.2' On 2014/08/29 17:05:57, nweiz wrote: ...
6 years, 3 months ago (2014-08-29 17:12:09 UTC) #4
nweiz
https://codereview.chromium.org/518853002/diff/40001/pkg/yaml/pubspec.yaml File pkg/yaml/pubspec.yaml (right): https://codereview.chromium.org/518853002/diff/40001/pkg/yaml/pubspec.yaml#newcode14 pkg/yaml/pubspec.yaml:14: sdk: '>=1.5.0 <2.0.2' Why 2.0.2?
6 years, 3 months ago (2014-08-29 17:20:04 UTC) #5
kevmoo
PTAL https://codereview.chromium.org/518853002/diff/40001/pkg/yaml/pubspec.yaml File pkg/yaml/pubspec.yaml (right): https://codereview.chromium.org/518853002/diff/40001/pkg/yaml/pubspec.yaml#newcode14 pkg/yaml/pubspec.yaml:14: sdk: '>=1.5.0 <2.0.2' On 2014/08/29 17:20:04, nweiz wrote: ...
6 years, 3 months ago (2014-08-29 20:50:47 UTC) #6
nweiz
lgtm
6 years, 3 months ago (2014-08-29 21:08:07 UTC) #7
kevmoo
6 years, 3 months ago (2014-08-29 21:17:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 39711 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698