Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 51883006: Revert "Substitute types in generic superclasses and interfaces." (Closed)

Created:
7 years, 1 month ago by zarah
Modified:
7 years, 1 month ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Substitute types in generic superclasses and interfaces." This reverts commit r29545. Committed: https://code.google.com/p/dart/source/detail?r=29553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -313 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 16 chunks +55 lines, -95 lines 0 comments Download
M sdk/lib/_internal/lib/js_rti.dart View 4 chunks +7 lines, -13 lines 0 comments Download
M tests/lib/lib.status View 3 chunks +10 lines, -4 lines 0 comments Download
M tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart View 4 chunks +10 lines, -25 lines 0 comments Download
M tests/lib/mirrors/generic_bounded_test.dart View 5 chunks +8 lines, -26 lines 0 comments Download
M tests/lib/mirrors/generic_f_bounded_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
D tests/lib/mirrors/generic_superclass_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
M tests/lib/mirrors/generic_type_mirror_test.dart View 4 chunks +6 lines, -18 lines 0 comments Download
M tests/lib/mirrors/generics_substitution_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zarah
TBR.
7 years, 1 month ago (2013-10-30 15:15:04 UTC) #1
zarah
Committed patchset #1 manually as r29553 (presubmit successful).
7 years, 1 month ago (2013-10-30 15:19:06 UTC) #2
ngeoffray
7 years, 1 month ago (2013-10-30 15:19:37 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698