Issue 51883004: Let the stream of File:openRead handle cancel correctly.

Issue 51883004: Let the stream of File:openRead handle cancel correctly. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Let the stream of File:openRead handle cancel correctly. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29534

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -1 line)			Patch
M	sdk/lib/io/file_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/directory_list_pause_test.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/standalone/io/file_stream_test.dart	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

https://chromiumcodereview.appspot.com/51883004/diff/1/tests/standalone/io/file_stream_test.dart File tests/standalone/io/file_stream_test.dart (right): https://chromiumcodereview.appspot.com/51883004/diff/1/tests/standalone/io/file_stream_test.dart#newcode43 tests/standalone/io/file_stream_test.dart:43: .then((_) { Maybe add a comment here (and in ...

7 years, 1 month ago (2013-10-30 11:39:13 UTC) #2

Anders Johnsen

https://codereview.chromium.org/51883004/diff/1/tests/standalone/io/file_stream_test.dart File tests/standalone/io/file_stream_test.dart (right): https://codereview.chromium.org/51883004/diff/1/tests/standalone/io/file_stream_test.dart#newcode43 tests/standalone/io/file_stream_test.dart:43: .then((_) { On 2013/10/30 11:39:13, Søren Gjesse wrote: > ...

7 years, 1 month ago (2013-10-30 11:40:45 UTC) #4

Anders Johnsen

7 years, 1 month ago (2013-10-30 11:44:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r29534 (presubmit successful).

Expand Messages | Collapse Messages