Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 51843005: Emit a compile-time error when using default values in a redirecting factory. (Closed)

Created:
7 years, 1 month ago by karlklose
Modified:
7 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Emit a compile-time error when using default values in a redirecting factory. BUG=13663 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=29543

Patch Set 1 #

Patch Set 2 : Language status changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +9 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +24 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 1 month ago (2013-10-30 12:17:03 UTC) #1
Johnni Winther
lgtm
7 years, 1 month ago (2013-10-30 12:29:10 UTC) #2
karlklose
7 years, 1 month ago (2013-10-30 13:30:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29543 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698