Issue 517513002: Bugfix in dart:io's WebSocketTransformer implementation, correctly test async behaviour of websocke…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 517513002: Bugfix in dart:io's WebSocketTransformer implementation, correctly test async behaviour of websocke… (Closed)

Created:
6 years, 3 months ago by kustermann

Modified:
6 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Bugfix in dart:io's WebSocketTransformer implementation, correctly test async behaviour of websocket, some test cleanup R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39641

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
	M	dart/sdk/lib/io/websocket_impl.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	dart/tests/standalone/io/web_socket_test.dart	View		5 chunks	+18 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

kustermann

kustermann@google.com changed reviewers: + sgjesse@google.com

6 years, 3 months ago (2014-08-28 09:57:41 UTC) #1

Søren Gjesse

LGTM! Thanks for fixing this. We should merge this to 1.6.

6 years, 3 months ago (2014-08-28 10:07:09 UTC) #3

kustermann

6 years, 3 months ago (2014-08-28 10:44:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 39641 (presubmit successful).