Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 517243003: Add unit tests for the JSON format of several of our object types. (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add unit tests for the JSON format of several of our object types. I am going to change the format soon and I wanted testing in place beforehand. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39876

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -0 lines) Patch
M runtime/vm/object_test.cc View 1 2 3 4 1 chunk +278 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
6 years, 3 months ago (2014-08-29 20:27:11 UTC) #2
turnidge
6 years, 3 months ago (2014-09-03 16:57:49 UTC) #4
Cutch
lgtm with comments https://codereview.chromium.org/517243003/diff/60001/runtime/vm/object_test.cc File runtime/vm/object_test.cc (right): https://codereview.chromium.org/517243003/diff/60001/runtime/vm/object_test.cc#newcode4228 runtime/vm/object_test.cc:4228: static void stripValue(const char* value, const ...
6 years, 3 months ago (2014-09-03 17:12:16 UTC) #5
turnidge
6 years, 3 months ago (2014-09-04 16:22:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 39876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698