Issue 516863002: Revert revision 39617 "Create isolates in a separate thread."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 516863002: Revert revision 39617 "Create isolates in a separate thread." (Closed)

Created:
6 years, 3 months ago by ricow1

Modified:
6 years, 3 months ago

Reviewers:
vsm, turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert revision 39617 "Create isolates in a separate thread." This is breaking dartium with: BrowserOutput.stderr: ../../dart/runtime/vm/dart_api_impl.cc:1614: error: Dart_EnterScope expects there to be a current isolate. Did you forget to call Dart_CreateIsolate or Dart_EnterIsolate? R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=39638

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -94 lines)			Patch
M	runtime/lib/isolate.cc	View	5 chunks	+56 lines, -62 lines	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	2 chunks	+22 lines, -22 lines	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 (id:1) manually as r39638 (presubmit successful).

6 years, 3 months ago (2014-08-28 09:53:07 UTC) #3

Message was sent while issue was closed.

PS, this did also break pub bots

Expand Messages | Collapse Messages