Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issue 516673002: Tweaks for refactoring tests. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tweaks for refactoring tests. Mostly the push of 'assertSuccessfulRefactoring' into abstract RefactoringTest. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -51 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-08-27 21:44:45 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-08-28 06:59:53 UTC) #2
scheglov
6 years, 3 months ago (2014-08-28 15:15:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39658 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698