Issue 516643004: Do not use the OS and ARCH name in the snapshot version string (it causes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 516643004: Do not use the OS and ARCH name in the snapshot version string (it causes (Closed)

Created:
6 years, 3 months ago by siva

Modified:
6 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Do not use the OS and ARCH name in the snapshot version string (it causes mismatches when a snapshot is created on one machine/architecture and read on another machine/architecture). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39622

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -6 lines)			Patch
M	runtime/vm/snapshot.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/version.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/version_in.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

siva

asiva@google.com changed reviewers: + johnmccutchan@google.com

6 years, 3 months ago (2014-08-27 21:31:12 UTC) #1

siva

6 years, 3 months ago (2014-08-27 21:38:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r39622 (presubmit successful).