Issue 516463007: Create unit tests for analyzer2dart/driver.

Issue 516463007: Create unit tests for analyzer2dart/driver. (Closed)

Created:
6 years, 3 months ago by Paul Berry

Modified:
6 years, 3 months ago

Reviewers:
Johnni Winther, jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Create unit tests for analyzer2dart/driver. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39647

Patch Set 1 #

Total comments: 3

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -1 line)			Patch
	M	pkg/analyzer2dart/lib/src/driver.dart	View		1 chunk	+16 lines, -1 line	0 comments	Download
	A	pkg/analyzer2dart/test/driver_test.dart	View		1 chunk	+62 lines, -0 lines	3 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

paulberry@google.com changed reviewers: + johnniwinther@google.com, jwren@google.com

6 years, 3 months ago (2014-08-28 11:12:18 UTC) #1

Paul Berry

Committed patchset #1 manually as 39647 (presubmit successful).

6 years, 3 months ago (2014-08-28 11:19:43 UTC) #4

Johnni Winther

lgtm https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/driver_test.dart File pkg/analyzer2dart/test/driver_test.dart (right): https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/driver_test.dart#newcode42 pkg/analyzer2dart/test/driver_test.dart:42: FunctionElement entryPoint = driver.resolveEntryPoint(driver.setFakeRoot(contents)); Long line. https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/driver_test.dart#newcode44 pkg/analyzer2dart/test/driver_test.dart:44: ...

6 years, 3 months ago (2014-08-28 11:25:29 UTC) #5

Paul Berry

6 years, 3 months ago (2014-08-28 12:41:12 UTC) #6

Message was sent while issue was closed.

On 2014/08/28 11:25:29, Johnni Winther wrote:
> lgtm
> 
>
https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/drive...
> File pkg/analyzer2dart/test/driver_test.dart (right):
> 
>
https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/drive...
> pkg/analyzer2dart/test/driver_test.dart:42: FunctionElement entryPoint =
> driver.resolveEntryPoint(driver.setFakeRoot(contents));
> Long line.
> 
>
https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/drive...
> pkg/analyzer2dart/test/driver_test.dart:44: driver.computeWorld(entryPoint);
> This could fit in one line.
> 
>
https://codereview.chromium.org/516463007/diff/1/pkg/analyzer2dart/test/drive...
> pkg/analyzer2dart/test/driver_test.dart:46: CompilationUnitElement
> compilationUnit = entryPoint.getAncestor((e) => e is CompilationUnitElement);
> Ditto.

You're right, I forgot to hit "reformat".  I'll fix in the next CL.

Expand Messages | Collapse Messages