Minor changes to avoid handle creation.

- Make Parser::ReceiverType an instance method so that it has access to 'I'
- Minor changes to avoid handle creation.
- Fix snapshot version check error message.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39815

[siva, 2014-09-03 14:32:53]

asiva@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2014-09-03 15:41:51]

lgtm

https://codereview.chromium.org/516303006/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/516303006/diff/20001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:9410: Isolate* isolate = Isolate::Current();
Parser has a field isolate_

https://codereview.chromium.org/516303006/diff/20001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:9416: isolate, Type::New(cls, type_arguments,
cls.token_pos()));
s/isolate/I

[siva, 2014-09-03 18:27:58]

https://codereview.chromium.org/516303006/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/516303006/diff/20001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:9410: Isolate* isolate = Isolate::Current();
On 2014/09/03 15:41:50, srdjan wrote:
> Parser has a field isolate_

Parser::ReceiverType was a static method and isolate_ is not available.

I saw that there was no need for it to be a static method, I converted
it to an instance methods and now access isolate().

https://codereview.chromium.org/516303006/diff/20001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:9416: isolate, Type::New(cls, type_arguments,
cls.token_pos()));
On 2014/09/03 15:41:50, srdjan wrote:
> s/isolate/I

Done.

[siva, 2014-09-03 18:29:17]

Committed patchset #4 (id:60001) manually as r39815 (presubmit successful).