Fixes in the Outline type generation and some cleanup in codegen_java_types.dart

Fixes in the Outline type generation and some cleanup in codegen_java_types.dart

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39666

[jwren, 2014-08-28 16:51:15]

jwren@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

[scheglov, 2014-08-28 17:03:45]

lgtm

https://codereview.chromium.org/515953002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java
(right):

https://codereview.chromium.org/515953002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java:105:
if (outlineObject.has("children")) {
I don't think you need this check, outlineObject.get() will return null if there
are no object, and null is not a JsonArray.

[jwren, 2014-08-28 17:09:18]

https://codereview.chromium.org/515953002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java
(right):

https://codereview.chromium.org/515953002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java:105:
if (outlineObject.has("children")) {
On 2014/08/28 17:03:45, scheglov wrote:
> I don't think you need this check, outlineObject.get() will return null if
there
> are no object, and null is not a JsonArray.

Done.

[jwren, 2014-08-28 17:11:27]

Committed patchset #2 (id:20001) manually as 39666 (presubmit successful).

[Brian Wilkerson, 2014-08-28 19:17:12]

LGTM